guestagent: Fix isEmptyEvent check #3697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention seems to be checking if an event is equal to empty event, ignoring the event time, by copying the event and setting its time to nil. However instead of copying the event, we use the same object and set the event time to nil. I don't know if this caused a user visible problem, but it likely log wrong event time if we log the event. Signed-off-by: Nir Soffer <[email protected]>
AkihiroSuda
reviewed
Jul 7, 2025
| @@ -191,9 +191,8 @@ func (a *agent) collectEvent(ctx context.Context, st eventState) (*api.Event, ev | |||
|
|
|||
| func isEventEmpty(ev *api.Event) bool { | |||
| empty := &api.Event{} | |||
| copied := ev | |||
There was a problem hiding this comment.
This regression seems caused in v0.21
72b7cb7#diff-4e96077f852132abc5fce986b8a80ec455c810b1db00d2cb23dbc8c4d2d9a365L182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention seems to be checking if an event is equal to empty event, ignoring the event time, by copying the event and setting its time to nil. However instead of copying the event, we use the same object and set the event time to nil.
I don't know if this caused a user visible problem, but it likely log wrong event time if we log the event.
We can see the time in ha.stderr.log:
Before:
{ "level": "debug", "msg": "guest agent event: local_ports_added:{protocol:\"tcp\" ip:\"127.0.0.54\" port:53} local_ports_added:{protocol:\"tcp\" ip:\"127.0.0.53\" port:53} local_ports_added:{protocol:\"tcp\" ip:\"0.0.0.0\" port:22} local_ports_added:{protocol:\"tcp\" ip:\"0.0.0.0\" port:5355} local_ports_added:{protocol:\"tcp\" ip:\"::\" port:22} local_ports_added:{protocol:\"tcp\" ip:\"::\" port:5355} local_ports_added:{protocol:\"udp\" ip:\"127.0.0.54\" port:53} local_ports_added:{protocol:\"udp\" ip:\"127.0.0.53\" port:53} local_ports_added:{protocol:\"udp\" ip:\"127.0.0.1\" port:323} local_ports_added:{protocol:\"udp\" ip:\"0.0.0.0\" port:5355} local_ports_added:{protocol:\"udp\" ip:\"::1\" port:323} local_ports_added:{protocol:\"udp\" ip:\"::\" port:5355}", "time": "2025-07-06T15:16:53+03:00" }After:
{ "level": "debug", "msg": "guest agent event: time:{seconds:1751804380 nanos:651834360} local_ports_added:{protocol:\"tcp\" ip:\"0.0.0.0\" port:5355} local_ports_added:{protocol:\"tcp\" ip:\"127.0.0.53\" port:53} local_ports_added:{protocol:\"tcp\" ip:\"127.0.0.54\" port:53} local_ports_added:{protocol:\"tcp\" ip:\"0.0.0.0\" port:22} local_ports_added:{protocol:\"tcp\" ip:\"::\" port:5355} local_ports_added:{protocol:\"tcp\" ip:\"::\" port:22} local_ports_added:{protocol:\"udp\" ip:\"127.0.0.54\" port:53} local_ports_added:{protocol:\"udp\" ip:\"127.0.0.53\" port:53} local_ports_added:{protocol:\"udp\" ip:\"127.0.0.1\" port:323} local_ports_added:{protocol:\"udp\" ip:\"0.0.0.0\" port:5355} local_ports_added:{protocol:\"udp\" ip:\"::1\" port:323} local_ports_added:{protocol:\"udp\" ip:\"::\" port:5355}", "time": "2025-07-06T15:19:40+03:00" }